I've seen basically every question and answer on here relating to impedance matching, and why you need it in RF but not in audio applications, and I'm still missing something.
Impedance matching gives you maximum power transfer and also minimizes reflections. You use impedance matching where power is scarce (often arising with an antenna, microphone or sensor), or where reflections are problematic (e.g. preserving signal bandwidth in general or waveform edges in particular). This is not an exhaustive list.
It's good that you are trying to understand noise and matching, but I think the rest of your post and answer is wrong.
Firstly,
\$\text{SNR}(R_L) = \frac{\frac{\left(\frac{R_L10}{R_L+R_S}\right) ^2}{R_L}}{\frac{\left(\frac{R_L\left(\sqrt{4kTBR_S}+\sqrt{4kTBR_L}\right)}{R_L+R_S}\right) ^2}{R_L}}\$
you seem to be adding the amplitudes of incoherent noise sources in
\$\sqrt{4kTBR_S}+\sqrt{4kTBR_L}\$, the correct thing to do is to add their powers.
What you appear to be trying to show is that if you have a passive circuit (e.g. attenuator), then you get the best S/N at the output if the input is matched. This is easily proven, can I suggest that you try using power waves - this is a simple linear transformation, instead of using \$V\$ and \$I\$ you use:
\$(V+IZ_0)/\sqrt{Z_0}\$ and \$(V-IZ_0)/\sqrt{Z_0}\$
so, for example, if \$Z_0\$ is the source resistance, then the available noise power from the source is \$kT\$ per unit Hz.
When it comes to active devices, in particular LNAs, this analysis is not appropriate, particularly as the input impedance of an active device does not generally exhibit Johnson noise. There is a lot of material in the literature, including a famous paper "The theory of noisy fourpoles", then any book / paper / uni course notes on scattering parameter design of low noise amplifiers. The best S/N from a LNA is generally not when the input is matched.
Update
I think your analysis is flawed. Let's start with basics

The power available from the source is \$P_{avs}=\frac{V_s^2}{4r}\$, and if you define the reflection coefficient \$\Gamma=\frac{R-Z_s}{R+Z_s}\$, then the power dissipated in the load \$P_L=P_{avs}(1-|\Gamma|^2)\$. The available noise power from the source is kT (as long as \$r>0\$), so the noise power from the source that is dissipated in the load is \$N_L=kT(1-|\Gamma|^2)\$
Any lossless matching circuit you place between the source and the load to change \$\Gamma\$ (typically trying to reduce it), changes the signal power and the noise equally, hence it doesn't change the SNR.
Now you seem to be interested in the total noise voltage across R including the noise from \$R\$ itself. This usually doesn't apply as normally \$R\$ represents an active device which doesn't normally exhibit Johnson noise from it's input impedance, and we include the effect of it's noise in the noise figure. But let's see what happens:

Working out the contribution to \$V_R\$ from \$e_n\$, let's simplify the maths by assuming \$Z = r\$, real.
\$V_R=e_n\frac{r}{r+R}\$
noting that the voltage across the physical resistor \$R\$ includes the internal noise source.
using \$1-|\Gamma|^2 = \frac{4rR}{(r+R)^2}\$
you can show \$V_R^2 = kTr(1-|\Gamma|^2)\$
Now our previous quantities are powers dissipated in \$R\$, so we could convert the previous quantities to voltage, or convert this to equivalent power. I chose to convert this to equivalent power, hence
\$N_{eq} = \frac{V_R^2}{R} = kT(1-\Gamma)^2\$
So the total equivalent noise power dissipated in \$R\$ is
\$N = kT((1-|\Gamma|^2) + (1-\Gamma)^2) = 2kT(1-\Gamma)\$
Hence \$SNR = \frac{P_{avs}}{2kT}(1+\Gamma)\$
So if your detector measures the voltage across \$R\$, you get max SNR if \$\Gamma=1\$, i.e. an open circuit. This is the actual SNR you would measure into an ideal matched load with a noise figure of 0dB.
I haven't done the analysis, but I suspect that if your detector was measuring the current into the load you would find that the SNR is max when \$\Gamma=-1\$, i.e. a short circuit.
I haven't looked at \$x\neq0\$, I can't imagine it's much different, only more complicated.
As an example as to why you are unlikely to use this, the ADI LT1028 op amp has an input impedance of about 20k, which if it exhibited Johnson noise would have a noise spectral density of about \$18nV/\sqrt{Hz}\$, but the actual input noise voltage density is around \$1nV/\sqrt{Hz}\$.
In reality, you are usually passing weak signals to some sort of low noise amplifier, if this device has constant equivalent additive input noise, then you get maximum SNR when you maximize the input signal - i.e. matching the input. Typically the input noise varies somewhat with matching which complicates things. See texts on low noise amplifier design.